Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/http-static-variable #950

Closed
wants to merge 4 commits into from
Closed

bugfix/http-static-variable #950

wants to merge 4 commits into from

Conversation

pvannierop
Copy link
Collaborator

@pvannierop pvannierop commented Sep 4, 2024 •
edited
Loading

Description:

This PR will apply a hotfix that fixes:

  • spurious instantiation of the Ktor HttpClient used for Jwt validation
  • redundant token validation by using Jwt token present in the HTTP session

Checklist:

  • The Main workflow has succeeded
  • The Gatling tests have passed
  • I have logged into the portal running locally with default admin credentials:
    image
  • I have updated the README files if this change requires documentation update
  • I have commented my code, particularly in hard-to-understand areas

@pvannierop pvannierop self-assigned this Sep 4, 2024
yatharthranjan
yatharthranjan approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pvannierop
Copy link
Collaborator Author

pvannierop commented Sep 6, 2024 •
edited
Loading

@yatharthranjan I think we are good here regarding the failing Snyk tests?

@pvannierop pvannierop closed this Sep 9, 2024
@pvannierop pvannierop deleted the bugfix/http-static-variable branch September 9, 2024 07:41
@pvannierop pvannierop restored the bugfix/http-static-variable branch September 9, 2024 07:41
@pvannierop
Copy link
Collaborator Author

pvannierop commented Sep 9, 2024 •
edited
Loading

The feature branch of this PR was pushed under name v2.1.3 and a release was derived from it. This PR will not be merged to master.

@pvannierop pvannierop reopened this Sep 9, 2024
@pvannierop pvannierop closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan approved these changes

@nivemaham nivemaham Awaiting requested review from nivemaham nivemaham is a code owner

@Bdegraaf1234 Bdegraaf1234 Awaiting requested review from Bdegraaf1234 Bdegraaf1234 is a code owner

@peyman-mohtashami peyman-mohtashami Awaiting requested review from peyman-mohtashami peyman-mohtashami is a code owner

@mpgxvii mpgxvii Awaiting requested review from mpgxvii mpgxvii is a code owner

Assignees

@pvannierop pvannierop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvannierop @yatharthranjan @Bdegraaf1234